Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1341] allow media and tables to span full width #756

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[R20-1341] allow media and tables to span full width #756

merged 1 commit into from
Aug 10, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 9, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1341

What I did

  • To match Ripple 1 we now allow media elements and tables to span full width, instead of being capped to the max-content-width of 615px

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 9, 2023
@codesandbox
Copy link

codesandbox bot commented Aug 9, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Aug 9, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit b54b6cc
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64d33dd2d36486000758dd54

@cypress
Copy link

cypress bot commented Aug 9, 2023

Passing run #304 ↗︎

0 85 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): allow tables and media elements to span full width
Project: ripple-framework Commit: b54b6cce3f
Status: Passed Duration: 04:36 💡
Started: Aug 9, 2023 7:17 AM Ended: Aug 9, 2023 7:22 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@waitingallday waitingallday merged commit 0f85bce into develop Aug 10, 2023
13 checks passed
@waitingallday waitingallday deleted the bugfix/allow-wider-media-content branch August 10, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@lambry lambry

Labels
Needs Code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @jeffdowdle